Skip to content

Remove unneeded file property #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 14, 2018
Merged

Remove unneeded file property #1790

merged 2 commits into from
Jan 14, 2018

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 14, 2018

This causes HTML to be really huge

reported by @lcxfs1991

This causes HTML to be really huge
@dear-lizhihua
Copy link
Collaborator

image
npm run build, show error: 'page.file.attributes', i think you should delete sort function

Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this was caused by #1759, thanks for the fix @sokra and thanks for reporting and reviewing @dear-lizhihua.

@skipjack skipjack merged commit 04cb253 into master Jan 14, 2018
@skipjack skipjack deleted the bugfix/html-size branch January 14, 2018 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants