Skip to content

docs(concepts): Simplified the Loaders section #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 18, 2018

Conversation

adambraimbridge
Copy link

docs(concepts): Simplified the Loaders section to be clearer for complete beginners like me.

@jsf-clabot
Copy link

jsf-clabot commented Jan 12, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these tweaks, please see my minor comments so we can get this merged.

@@ -72,14 +72,15 @@ T> The `output` property has [many more configurable features](/configuration/ou

*Loaders* enable webpack to process more than just JavaScript files (webpack itself only understands JavaScript). They give you the ability to leverage webpack's bundling capabilities for all kinds of files by converting them to valid [modules](/concepts/modules) that webpack can process.

Essentially, webpack loaders transform all types of files into modules that can be included in your application's dependency graph.
Essentially, webpack loaders transform all types of files into modules that can be included in your application's dependency graph (and eventually your bundle).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would rephrase as and eventually a bundle as users might have multiple.

At a high level, __loaders__ have two purposes in your webpack configuration:

1. The `test` property identifies which file or files should be transformed.
2. The `use` property says which loader should be used to do the transforming.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this change but two minor nitpicks:

  • Can you change says in 2. to indicates?
  • Can you drop the additional blank line (83)? Typically we only include two line breaks before h2 headers.

Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for making the updates @adambraimbridge!

@skipjack skipjack merged commit 69b84ff into webpack:master Jan 18, 2018
@adambraimbridge adambraimbridge deleted the loaders-documentation branch January 29, 2018 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants