docs(concepts): Direct new-comers to read about JS modules #1773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because new-comers may have an easier time to understand webpack and why it is needed when they read about JS modules.
The article describes and discusses module systems in JS.
skipjack
requested changes
Jan 7, 2018
src/content/concepts/index.md
Outdated
| @@ -12,6 +12,8 @@ contributors: | |||
|
|
|||
| At its core, *webpack* is a _static module bundler_ for modern JavaScript applications. When webpack processes your application, it recursively builds a _dependency graph_ that includes every module your application needs, then packages all of those modules into one or more _bundles_. | |||
|
|
|||
| T> Learn more about JavaScript modules and webpack modules [here](/modules). | |||
There was a problem hiding this comment.
Shouldn't the link be to /concepts/modules -- e.g. here.
skipjack
approved these changes
Jan 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a direction to learn about JS modules when reading the concepts page, meant mostly for new-comers. Because the modules doc page does not discuss the JS module systems, I also added a further reading link on this subject.
This is after a colleague of mine had an issue understanding what and why about webpack when reading the docs. What he was missing is an understanding of JS modules. You can't understand a module bundler without knowing modules.