Skip to content

docs(configuration): add details on resolve.symlink and npm link #1771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2018

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented Jan 3, 2018

From discussion in webpack/webpack#811 (comment).

Adds a few notes about how resolve.symlinks and npm link play together (I assume npm link to be the most common tool for symlinking packages). Specifically, turning off resolve.symlinks may solve some problems users have with modules not resolving properly in their symlinked packages.

Copy link
Collaborator

@ChrisChinchilla ChrisChinchilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sohkai Thanks for your submission, this looks good to me from a written perspective.

Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made one minor grammar tweak, aside from that this looks great, thanks!

@skipjack skipjack merged commit 073c11d into webpack:master Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants