Skip to content

Fix typo in sourceType example. #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2017
Merged

Fix typo in sourceType example. #1580

merged 1 commit into from
Sep 7, 2017

Conversation

barakd
Copy link
Contributor

@barakd barakd commented Sep 7, 2017

Fix typo in sourceType example from commonsjs2 to the correct one commonjs2

Before

There was a typo in the sourceType example, trying to run a build with that configuration will throw an error.
image

After

Fix the value to the correct name commonjs2.

@barakd
Fix typo in sourceType example.
ae321c0 
Fix typo in sourceType example from `commonsjs2` to the correct one `commonjs2`
@jsf-clabot
Copy link

jsf-clabot commented Sep 7, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

skipjack
skipjack approved these changes Sep 7, 2017
View reviewed changes
Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks @barakd!

@skipjack skipjack merged commit 69b479f into webpack:master Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skipjack skipjack skipjack approved these changes

Assignees
No one assigned
Labels
Correction Plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barakd @jsf-clabot @skipjack