Mention Python dependency in contribution guide #1524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skipjack
requested changes
Aug 14, 2017
There was a problem hiding this comment.
This is definitely a good thing to note and something that we should maybe reconsider at some point. The only things I would say is that you should probably add that it's only required for our npm run lint script and maybe put it after the note about the node dependency since the correct Node version is more important.
|
@skipjack I got an error when I ran |
|
Ah ok nvm mentioning 'npm run lint' then. |
|
OK @skipjack updated the order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs(contributing): Mention Python dependency