Option for listening to unix socket #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resure
changed the title
11 tasks
SpaceK33z
requested changes
Oct 25, 2016
| Start dev server in socket mode: | ||
|
|
||
| ```shell | ||
| node ../../bin/webpack-dev-server.js --open --socket ./webpack.sock |
There was a problem hiding this comment.
Can you remove --open here since it opens the wrong URL in this case?
| location /webpack/ { | ||
| proxy_pass http://unix:/home/happywebpackuser/apps/todo/webpack.sock; | ||
| proxy_set_header Host $host; | ||
| proxy_set_header X-Real-IP $remote_addr; |
|
Done, I've appended that changes to the last commit. |
SpaceK33z
approved these changes
Oct 27, 2016
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
examples/(for features)What kind of change does this PR introduce?
What is the current behavior?
#659
It's possible to pass socket path as port param but it won't correctly handle access rights (chmod) to socket and
EADDRINUSEerrors.What is the new behavior?
New option
--socketadded. It overrides port if present and adds additional handling to listen:EADDRINUSEerror) then socket file is already present. In this case, we're trying to connect to that socket file.www-data).Does this PR introduce a breaking change?