Skip to content

refactor: better types #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2024
Merged

refactor: better types #1801

merged 2 commits into from
Mar 29, 2024

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • documentation update
  • typo fix
  • metadata update

Motivation / Use-Case

Also added TODO for the next major release, we don't make a redirect when make /public/file.ext request and when file.ext is the file, it is a rare case, but will be great to fix it in future

Breaking Changes

No

Additional Info

No

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (1f54424) to head (40c4a5f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1801   +/-   ##
=======================================
  Coverage   96.25%   96.25%           
=======================================
  Files          13       13           
  Lines         695      695           
  Branches      206      206           
=======================================
  Hits          669      669           
  Misses         25       25           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-akait alexander-akait merged commit 7b666a1 into master Mar 29, 2024
@alexander-akait alexander-akait deleted the refactor-better-types branch March 29, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant