Skip to content

Fix: fix the 'undefined' string in the css file issue. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2015
Merged

Fix: fix the 'undefined' string in the css file issue. #5

merged 1 commit into from
Apr 26, 2015

Conversation

fubupc
Copy link
Contributor

@fubupc fubupc commented Apr 26, 2015

There is an incorrect 'undefined' string in the css file after processing by
source-map-loader.

It's caused by the line

callback(null, input.replace(match[0], match[2]), map);

There are two kinds of comment format regex1 and regex2. regex1 only have one capture group so match[2] will be undefined. So maybe just replace by empty would be OK?

There is an incorrect 'undefined' string in the css file after processing by
source-map-loader.
sokra added a commit that referenced this pull request Apr 26, 2015
Fix: fix the 'undefined' string in the css file issue.
@sokra sokra merged commit 087c921 into webpack-contrib:master Apr 26, 2015
@sokra
Copy link
Member

sokra commented Apr 26, 2015

Thanks

@fubupc
Copy link
Contributor Author

fubupc commented Apr 27, 2015

@sokra No thanks :)

BTW, could you update the package on www.npmjs.com? I found that I can't update the package using npm update.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants