chore: remove unused dependency (source-map)

[diegofaria]

No description provided.

[jsf-clabot]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

[alexander-akait]

@diegofaria why?

[diegofaria]

it looks like its not being used by the code, or i am too newbie?! x)

[alexander-akait]

Seems SourceMap never used https://github.com/webpack-contrib/source-map-loader/blob/v0.1.1/index.js.

/cc @d3viant0ne

[michael-ciniawsky]

@diegofaria Thx, could you please remove the dependency from package.json aswell ? 😛

[diegofaria]

I don't really know if it tests without SourcMap depedency will maintain the same purpose.
Can someone check?

@d3viant0ne @michael-ciniawsky @evilebottnawi

[joshwiens]

@diegofaria - You need to sign the CLA before this can be merged.

[diegofaria]

I already did it @d3viant0ne :)

[michael-ciniawsky]

The with keyword is absolutely discouraged to use, quoting MDN here for reference

Using with is not recommended, and is forbidden in ECMAScript 5 strict mode. The recommended alternative is to assign the object whose properties you want to access to a temporary variable.

The question is if we still need it or if this is technical dept in the tests aswell (like the left over require in the loader itself), since the loader works without it, guessing that's likely to be the case :)
I can't for instance see how this is utilized, the expected value, just contains the 'with Sourcemap' {String} ¯_(ツ)_/¯. It's really weird 😛

[joshwiens]

This looks to me like tech debt but as @michael-ciniawsky said, it's just weird. We should probably ask Tobias just to be sure we aren't missing some sourcemap nuance that isn't apparent here.

[michael-ciniawsky]

@zuohaocheng Do you have any idea why the withkeyword is used in the test and if it's still needed ? Otherwise I need to ask Tobias about it :D

[zuohaocheng]

@michael-ciniawsky I'm not sure, but it looks more like a comment for me, as these are not real JavaScript file: without is definitely an illegal token. I would prefer to preserve them, and if possible, make it more clear to show these are not files in specific language.

What is done in source-map-loader does not include parsing the JavaScript file, as it only uses regex to match source map directive. As my understanding, it should be able to be used with other types of file, say, css.

[zuohaocheng]

It's great to remove unused dependencies. Meanwhile I'm not sure whether it's a good practice to remove those withs, because those files do not have to valid JavaScript file.

[diegofaria]

What do you guys think it's left here?

@zuohaocheng @michael-ciniawsky

[zuohaocheng]

@diegofaria Please kindly correct me if it's not the case. As mentioned in earlier comment, I think it would be nice to leave those withs as comment in test cases.

Removing unused dependency looks perfect forme.

[diegofaria]

@zuohaocheng can you check if now it is correct?

[StarpTech]

What's the status?

[alexander-akait]

/cc @diegofaria need accept CLA and rebase