Skip to content

chore: remove Node.js 4, add Node.js 10 #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: remove Node.js 4, add Node.js 10 #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,17 @@ jobs:
env: WEBPACK_VERSION=latest JOB_PART=coverage
script: npm run travis:$JOB_PART
after_success: 'bash <(curl -s https://codecov.io/bash)'
- <<: *test-latest
node_js: 10
env: WEBPACK_VERSION=latest JOB_PART=test
script: npm run travis:$JOB_PART
- stage: Webpack canary
before_script: yarn add git://github.com/webpack/webpack.git#master
script: npm run travis:$JOB_PART
node_js: 8
env: WEBPACK_VERSION=canary JOB_PART=test
before_install:
- 'if [[ `npm -v` != 5* ]]; then npm i -g npm@^5.0.0; fi'
- npm i -g npm@latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm@6 don't support node 4 left this as is

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node 4 is EOL and fails (see the failing unit tests of the last commits in the master branch).

- nvm --version
- node --version
- npm --version
Expand Down
6 changes: 3 additions & 3 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ init:
- git config --global core.autocrlf input
environment:
matrix:
- nodejs_version: '8'
- nodejs_version: '10'
webpack_version: latest
job_part: test
- nodejs_version: '6'
- nodejs_version: '8'
webpack_version: latest
job_part: test
- nodejs_version: '4.3'
- nodejs_version: '6'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove node@4, it will be remove when we drop node@4 support, just add node@10

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure? See the last commits and the failing test suite. The dependencies require node >= 6.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://circleci.com/gh/webpack-contrib/mini-css-extract-plugin/29

webpack_version: latest
job_part: test
build: 'off'
Expand Down