Skip to content

fix: do not handle empty attributes #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2020
Merged

fix: do not handle empty attributes #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export default function htmlLoader(source) {
let offset = 0;
for (const link of links) {
if (
link.value &&
isUrlRequest(link.value, options.root) &&
!link.value.includes('mailto:')
) {
Expand Down
5 changes: 3 additions & 2 deletions test/loader.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,14 @@ describe('loader', () => {
it('should convert to requires', () => {
const result = loader.call(
{},
'Text <img src="image.png"><img src="~bootstrap-img"> Text'
'Text <img src="image.png"><img src="~bootstrap-img"> Text <img src="">'
);

expect(result).toBe(
`${GET_URL_CODE}module.exports = "Text <img src=\\"" + __url__(require("./image.png")) + "\\"><img src=\\"" + __url__(require("bootstrap-img")) + "\\"> Text";`
`${GET_URL_CODE}module.exports = "Text <img src=\\"" + __url__(require("./image.png")) + "\\"><img src=\\"" + __url__(require("bootstrap-img")) + "\\"> Text <img src=\\\"\\\">";`
);
});

it('should accept attrs from query', () => {
const result = loader.call(
{
Expand Down