Skip to content
This repository was archived by the owner on Sep 28, 2020. It is now read-only.

docs: update gotchas #284

Merged
merged 1 commit into from
Jul 4, 2019
Merged

docs: update gotchas #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,11 @@ module.exports = {

## Gotchas

### NoErrorsPlugin
### NoEmitOnErrorsPlugin for `webpack >= 4`

`NoEmitOnErrorsPlugin` is now automatically enabled in webpack 4, when mode is either unset, or set to production. So even ESLint warnings will fail the build. No matter what error settings are used for `eslint-loader`, except if `emitWarning` enabled.

### NoErrorsPlugin for `webpack < 4`

`NoErrorsPlugin` prevents webpack from outputting anything into a bundle. So even ESLint warnings
will fail the build. No matter what error settings are used for `eslint-loader`.
Expand All @@ -316,7 +320,9 @@ See [#129](https://github.com/webpack-contrib/eslint-loader/issues/129).
---

## Changelog

[Changelog](CHANGELOG.md)

## License

[MIT](./LICENSE)