-
-
Notifications
You must be signed in to change notification settings - Fork 608
Init minimizeOptions
should be query.minimize
!
#400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's a mistake according to the doc. Init `minimizeOptions` should be `query.minimize` rather than just query. Please review it immediately. https://github.com/webpack/css-loader#minification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
If you could add a test, this would be ready to go in. |
@JounQin Please close and reopen the PR to trigger the CLA Bot again, should be working now 😛 |
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 9 9
Lines 306 306
Branches 69 69
=======================================
Hits 301 301
Misses 5 5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 9 9
Lines 306 306
Branches 69 69
=======================================
Hits 301 301
Misses 5 5
Continue to review full report at Codecov.
|
@bebraw @michael-ciniawsky |
@JounQin Thx 👍 |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
No
If relevant, did you update the README?
No need
Summary
It's a mistake according to the doc.
Init
minimizeOptions
should bequery.minimize
rather than justquery
.Please review it immediately.
https://github.com/webpack/css-loader#minification
Does this PR introduce a breaking change?
No