Skip to content

Init minimizeOptions should be query.minimize! #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 9, 2017
Merged

Init minimizeOptions should be query.minimize! #400

merged 4 commits into from
Mar 9, 2017

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Jan 15, 2017

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
No

If relevant, did you update the README?
No need

Summary
It's a mistake according to the doc.

Init minimizeOptions should be query.minimize rather than just query.

Please review it immediately.

https://github.com/webpack/css-loader#minification

Does this PR introduce a breaking change?

No

It's a mistake according to the doc.

Init `minimizeOptions` should be `query.minimize` rather than just query.

Please review it immediately.

https://github.com/webpack/css-loader#minification
@jsf-clabot
Copy link

jsf-clabot commented Jan 15, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bebraw
Copy link
Contributor

bebraw commented Mar 8, 2017

If you could add a test, this would be ready to go in.

@michael-ciniawsky
Copy link
Member

@JounQin Please close and reopen the PR to trigger the CLA Bot again, should be working now 😛
And please a a test 👍

@codecov
Copy link

codecov bot commented Mar 9, 2017

Codecov Report

Merging #400 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #400   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files           9        9           
  Lines         306      306           
  Branches       69       69           
=======================================
  Hits          301      301           
  Misses          5        5
Impacted Files Coverage Δ
lib/processCss.js 97.91% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9418a5a...58c41ce. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 9, 2017

Codecov Report

Merging #400 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #400   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files           9        9           
  Lines         306      306           
  Branches       69       69           
=======================================
  Hits          301      301           
  Misses          5        5
Impacted Files Coverage Δ
lib/processCss.js 97.91% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9418a5a...58c41ce. Read the comment docs.

@JounQin
Copy link
Contributor Author

JounQin commented Mar 9, 2017

@bebraw @michael-ciniawsky
Hi, all, I've fixed the error of CI test, and moduleMinimizeTest.js should have tested this feature already.

@michael-ciniawsky michael-ciniawsky merged commit 9999b2f into webpack-contrib:master Mar 9, 2017
@michael-ciniawsky
Copy link
Member

@JounQin Thx 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants