Fix output when hljs multi-line element contains an empty line #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a highlightjs multi-line element (for instance a multi-line comment)
contains an empty line, the resulting output numbered line was containing
a "{1}" string.
This fix handles the empty line special case.
swhmirror
pushed a commit
to SoftwareHeritage/swh-web
that referenced
this pull request
Sep 26, 2018
Until observed issue got fixed upstream, use a patched version that properly renders a multi-line comment in highlighted code. A pull request has been submitted to the original author: wcoder/highlightjs-line-numbers.js#48 Closes T1209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a highlightjs multi-line element (for instance a multi-line comment)
contains an empty line, the resulting output numbered line was containing
a "{1}" string.
This PR is an improvement over PR #43 and fixes issue #42.