Fix setup command #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding package.json script to first install yarn dependencies and then setup database
hirsch88
previously requested changes
Dec 17, 2017
| '.env' | ||
| db: { | ||
| script: series( | ||
| 'nps db.migrate', |
There was a problem hiding this comment.
To run typorm we have to create typorm.json first with nps config
There was a problem hiding this comment.
As db.migrate and db.seed already contain nps config we don't need this here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As nps isn't available before yarn install we can't yarn install in nps
Adding package.json script to first install yarn dependencies and then setup database
Probably fixes #43