Skip to content

Update store.watch() typing #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2016
Merged

Update store.watch() typing #492

merged 1 commit into from
Nov 29, 2016

Conversation

plievone
Copy link
Contributor

watch callback gives oldValue as the second parameter.
It may also be undefined in case {immediate: true} is used, but typing it optional could be inconvenient for most common uses.

watch callback gives `oldValue` as the second parameter.
It may also be `undefined` in case `{immediate: true}` is used, but typing it optional could be inconvenient for most common uses.
@ktsn
Copy link
Member

ktsn commented Nov 29, 2016

I think it would be a reasonable. Thanks.

@ktsn ktsn merged commit 3baa6b0 into vuejs:dev Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants