Skip to content

[docs] Align GitBook theming to main Vue.js site #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2016

Conversation

pearofducks
Copy link
Contributor

@pearofducks pearofducks commented Nov 8, 2016

One of the strengths Vue highlights is that these extra plugins are maintained by the core team. With this change, the documentation feels a lot more like this is true. :)

Note the lack of chapter numbers is not my doing, that seems to possibly be a change from GitBook 2 to 3 - but I do think it's better without them.

edit// Also, I'd recommend bumping the GitBook version in book.json if possible to >3.0.0, I couldn't get the current version to run locally. Let me know if this an OK change and I can add it here.

before

after

@ktsn
Copy link
Member

ktsn commented Nov 8, 2016

Looks good to me.
@yyx990803 What do you think?

@kazupon
Copy link
Member

kazupon commented Nov 8, 2016

awesome. 💯
if this theme is provided as the gitbook plugin, we can use it into the other vue docs.
we should be made the gitbook theme plugin.

@yyx990803
Copy link
Member

This is great! And +1 to what @kazupon said

@pearofducks
Copy link
Contributor Author

pearofducks commented Nov 9, 2016

Plugin made! This applies the css globally - except the language-selection screen (a limitation of GitBook).

I can make a PR for any other projects as well to update their book.json. Let me know if there's more than just vue-router. :)

@yyx990803 yyx990803 merged commit 6a12078 into vuejs:dev Nov 10, 2016
@yyx990803
Copy link
Member

@pearofducks thank you so much! Would appreciate PRs for vue-router and vue-loader as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants