Add some test and comments for module.js #1113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanzhiheng
force-pushed
the
feature/add-tests-for-module-js-with-some-comments
branch
from
ea20825 to
c9058f5
Compare
ktsn
reviewed
Jan 3, 2018
test/unit/module/module.spec.js
Outdated
|
|
||
| module.addChild('v1', new Module({})) | ||
| module.addChild('v2', new Module({})) | ||
| module.removeChild('v2') |
There was a problem hiding this comment.
We should also check the _children just before calling removeChild to confirm whether it actually works or not.
test/unit/module/module.spec.js
Outdated
| expect(module._rawModule).toEqual(originObject) | ||
|
|
||
| module.update(newObject) | ||
| expect(module._rawModule).not.toEqual(newObject) |
There was a problem hiding this comment.
I think this assertion is not needed because it does not matter whether the whole object strictly equals newObject or not.
There was a problem hiding this comment.
@ktsn Thank you for your comment, I will fix it today.
lanzhiheng
changed the title
lanzhiheng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.