Add Simple test case for base function utils #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinjiang
reviewed
Dec 21, 2017
|
@Jinjiang OK，I will remove it. Thanks. |
lanzhiheng
force-pushed
the
feature/add-test-for-utils
branch
from
ab64725 to
4f0974b
Compare
ktsn
approved these changes
Dec 28, 2017
ktsn
reviewed
Jan 3, 2018
test/unit/util.spec.js
Outdated
|
|
||
| describe('util', () => { | ||
| it('find', () => { | ||
| const list = [33, 22, 112, 222, 43] | ||
| expect(find(list, function (a) { return a % 2 })) |
There was a problem hiding this comment.
Sorry for reviewing after approved this but this does not specify an expected value. It looks always pass the test.
There was a problem hiding this comment.
😢 Sorry, I have updated it. @ktsn
lanzhiheng
force-pushed
the
feature/add-test-for-utils
branch
from
4f0974b to
1ae13ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.