Skip to content

Docs: fix a command bug #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Docs: fix a command bug #2237

wants to merge 1 commit into from

Conversation

ChungZH
Copy link
Contributor

@ChungZH ChungZH commented Mar 20, 2020

Summary
Fix a command bug in Chinese doc.

Before: yarn build:docs & npm run build:docs

After: yarn docs:build & npm run docs:build

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@billyyyyy3320
Copy link
Collaborator

It totally depends on what the property name you set to your NPM scripts

@billyyyyy3320
Copy link
Collaborator

billyyyyy3320 commented Mar 20, 2020

Oh, I get it. The example commands isn't sync between zh and en docs.

@ChungZH
Copy link
Contributor Author

ChungZH commented Mar 20, 2020

Haha, that's it 😄
Actually, this is not only isn't sync, this command is wrong.
Thx!

@meteorlxy
Copy link
Member

meteorlxy commented Apr 8, 2020

Sorry didn't notice this PR. Has already merged #2284

@meteorlxy meteorlxy closed this Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants