Skip to content

to make it easier for other people for the homepage #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrmuaz
Copy link

@jrmuaz jrmuaz commented Jan 17, 2020

I just have to search the internet for hours why I cant display the hero.png I made to my website

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

I just have to search the internet for hours why I cant display the hero.png I made to my website
@meteorlxy
Copy link
Member

Please fix the errors:

  • Semantic Pull Request
  • 'heroImage: /hero.png' => `heroImage: /hero.png`

@meteorlxy meteorlxy added the topic: docs Used when working with docs label Jan 17, 2020
@@ -35,6 +35,8 @@ Any extra content after the `YAML front matter` will be parsed as normal Markdow

To use a fully custom homepage layout, you can also use a [Custom Layout](#custom-layout-for-specific-pages).

For the 'heroImage: /hero.png' it is located in [public folder](../guide/assets.md#public-files).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'heroImage: /hero.png' => `heroImage: /hero.png`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: docs Used when working with docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants