Skip to content

feat($docs): Add Navbar Logo section for Default Theme Config (Closes #1932) #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2019
Merged

feat($docs): Add Navbar Logo section for Default Theme Config (Closes #1932) #1974

merged 1 commit into from
Oct 25, 2019

Conversation

CodesOfRa
Copy link
Collaborator

@CodesOfRa CodesOfRa commented Oct 23, 2019

Summary
Add the Navbar logo section in the docs, from v0 docs to v1 docs.
it's a fix for #1932

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • [x ] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@kefranabg kefranabg changed the title docs: Fix #1932 Add Navbar Logo section for Default Theme Config feat($docs): Add Navbar Logo section for Default Theme Config (Closes #1932) Oct 24, 2019
@ulivz
Copy link
Member

ulivz commented Oct 25, 2019

@newsbielt703 Could you help update the Chinese docs? Thanks!

@ulivz ulivz merged commit 6aaff68 into vuejs:master Oct 25, 2019
@vue-bot
Copy link

vue-bot commented Oct 25, 2019

Thanks again! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants