Skip to content

fix($docs): Broken link "Contribute" on README.md (fix #1953) #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2019
Merged

fix($docs): Broken link "Contribute" on README.md (fix #1953) #1954

merged 1 commit into from
Oct 14, 2019

Conversation

talkor
Copy link
Contributor

@talkor talkor commented Oct 14, 2019

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@kefranabg kefranabg changed the title docs: fix broken link to "Contribute" on README.md (fix #1953) fix($docs): Broken link "Contribute" on README.md (fix #1953) Oct 14, 2019
Copy link
Collaborator

@kefranabg kefranabg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@kefranabg kefranabg merged commit bc4032d into vuejs:master Oct 14, 2019
@vue-bot
Copy link

vue-bot commented Oct 14, 2019

Hey @talkor, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@talkor talkor deleted the edit-readme branch October 20, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants