On Windows, the chokidar watcher does not work well

[meteorlxy]

• OS: Windows 10 x64
• Node v8.11.1

Related to #346 , not only components, but also markdown files.

The current setting of chokidar only tracks the existed files, but does not track new files on Windows. (Maybe this is an issue of chokidar)

vuepress/lib/dev.js

Lines 30 to 41 in d9b290b

	// watch add/remove of files
	const pagesWatcher = chokidar.watch([
	path.join(sourceDir, '**/*.md'),
	path.join(sourceDir, '.vuepress/components/**/*.vue')
	], {
	ignored: '.vuepress/**/*.md',
	ignoreInitial: true
	})
	pagesWatcher.on('add', update)
	pagesWatcher.on('unlink', update)
	pagesWatcher.on('addDir', update)
	pagesWatcher.on('unlinkDir', update)

In addtion, unlinking a markdown/component file will cause an webapck error first, and then successfully compiled after the prepare finish. Could be enhanced somehow?

[hmatalonga]

Hello @meteorlxy

I am not being able to reproduce this error, I run vuepress dev, add/remove both markdown/component files (also following the mentioned folder tree in #346) and everything works fine for me.

I have tested with vuepress@0.7.0, vuepress@0.8.4 (installed via yarn global) and also directly from the master branch source. I also tried installing via npm i -g

Can you point another example where it causes this error?

[meteorlxy]

Maybe there is something to do with the OS?

Mine:

• Windows 10 x64
• Node v8.11.1

[meteorlxy]

@hmatalonga
I tested on Ubuntu 16.04 with node v8.11.1 and didn't have this problem.

[hmatalonga]

So that's probably a Windows related problem...

I have a Ubuntu-based distro and I am also using node v8.11.1 👍

[meteorlxy]

@hmatalonga What about removing files?

• After removing a file, an error of webpack occured first.
• Waiting for the prepare finished, new temp files generated.
• Another webpack compiling and then successfully compiled displayed.

Maybe this could be enhanced somehow?

[ulivz]

Looks like not a issue of VuePress:

Maybe this is an issue of chokidar.

I think that you can use chokidar to create a simple project, then you can open an issue to chokidar if you found any error.

In addtion, unlinking a markdown/component file will cause an webapck error first,

Same here, create a simple webpack project and test for unlinking and open an issue to webpack if found any error.

[meteorlxy]

@ulivz

The webpack error is not related to webpack.

When unlinking a file, webpack-serve and chokidar will both track the event. If webpack re-compile faster than vuepress's prepare process, an webpack error will occur first. I'll open another issue for that.

And the chokidar is the same as #346 and should be closed too.

[ulivz]

@meteorlxy

This issue is truly not a bug of webpack.

If webpack re-compile faster than vuepress's prepare process ...

No, the webpack re-compile will trigger twice. one is for the source file's add/remove/symlink event, while another one is the generated temp file by prepare.

Closing this bug is due to you were reporting a bug but assumed that it's not a bug of VuePress.

Update

I'll close #346 (I originally thought it also said the middle error, but not = =)

[hmatalonga]

@meteorlxy

Just to wrap up this,

Indeed after adding a component file and deleting the very same file will lead to the situation that @ulivz described here #351

However, it is possible that on Windows, besides this new issue, will still have problems with chokidar having to restart the dev server (which like you both said it does not seem a bug from vuepress itself)

[luisDanielRoviraContreras]

Then it will not work for my operating system or is there any way? because it really is very tedious to have to restart the server every time I add a new component and in my case I am doing a documentation migrating many components.