Skip to content

sidebarDepth: 0 not working in YAML #1701

Closed
@ragnarlotus

Description

@ragnarlotus
  • I confirm that this is an issue rather than a question.

Bug report

When using sidebarDepth: 0 in a page YAML the header links keep being displayed.

This is caused by the coalesce assignment in SidebarLink. Concretelly this piece of code:

    const configDepth = $page.frontmatter.sidebarDepth
      || sidebarDepth
      || $themeLocaleConfig.sidebarDepth
      || $themeConfig.sidebarDepth

Steps to reproduce

Just place the value in the top of the page:

---
sidebarDepth: 0
---

I have a repo with the current issue in my repo but I will try to find a workaround so can be fixed when you tested.

What is expected?

To do not show header links

What is actually happening?

It is showing h2 headers

Other relevant information

  • Output of npx vuepress info in my VuePress project:
    Environment Info:
    System:
    OS: Linux 5.0 Ubuntu 19.04 (Disco Dingo)
    CPU: (8) x64 Intel(R) Core(TM) i5-8350U CPU @ 1.70GHz
    Binaries:
    Node: 10.15.2 - /usr/bin/node
    Yarn: 1.16.0 - /usr/bin/yarn
    npm: 6.10.1 - ~/.node/bin/npm
    Browsers:
    Chrome: 75.0.3770.100
    Firefox: 68.0
    npmPackages:
    @vuepress/core: 1.0.2
    @vuepress/theme-default: 1.0.2
    vuepress: ^1.0.2 => 1.0.2
    npmGlobalPackages:
    vuepress: 1.0.2

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions