Skip to content

vuepress dev broken on nodejs v10 and greater #1063

Closed
@spiltcoffee

Description

@spiltcoffee
  • I confirm that this is a issue rather than a question.

Bug report

Version

vuepress 1.0.0-alpha.25

Steps to reproduce

Reproduction repo: https://github.com/spiltcoffee/vuepress-dev-crash
Note: Requires nodejs v10 or greater to reproduce.

What is expected?

vuepress dev to work

What is actually happening?

vuepress dev crashes.

I think it's related to PR #1051 / commit e570252

In nodejs v10, an underlying library made a change that broke doing things like reading a writable only stream.

This means the following line alone would now cause an error:

process.stdout.on('data', () => {});

The error actually occurs on nodejs v8, but it doesn't close the writable stream like it does on nodejs v10, which is, I'm guessing, why it wasn't noticed.

More info: nodejs/node#21203

Other relevant information

  • Your OS: Windows 10
  • Node.js version: v10.14.1
  • Browser version: Chrome 70
  • Is this a global or local install? Local
  • Which package manager did you use for the install? npm 6.1.0

p.s. sorry for not raising this as an issue earlier, instead insisting on commenting on a closed pull request. My bad!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions