-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
Necessary changes to observer for full Tracker compatibility #4652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
92fd14a
Necessary changes to observer for full Tracker compatibility.
mitar b949953
Code style.
mitar 1717fbb
Merge branch 'dev' into tracker-compatibility
mitar 4f637c6
Do not expose observer methods through util.
mitar b02988a
Merge branch 'dev' into tracker-compatibility
mitar 3808d5f
Fixing tests.
mitar 6424581
Missed file to commit.
mitar 078d2bb
Merge branch 'dev' into tracker-compatibility
mitar a592964
Merge branch 'dev' into tracker-compatibility
mitar dd6bd19
Fixed bad merge.
mitar e1ecf7a
Simpler import syntax.
mitar 81f06af
Merge branch 'dev' into tracker-compatibility
mitar 09f8aa6
Added isFlushing.
mitar f054458
Style.
mitar 7503c2e
Fixed an edge case in Tracker.nonreactive.
mitar 2fe7185
Merge branch 'dev' into tracker-compatibility
mitar 99483b7
Allow reference to watcher to be available during create.
mitar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you not using default import syntax?
L22:
import Watcher from '../observer/watcher'
L20:
import Dep, { pushTarget, popTarget } from '../observer/dep'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No particular reason. I can change it, if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find @znck syntax cleaner. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.