fix(v-model): ensure v-model listener trigger before listener with modifier(fix #11925) #11957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…difier This reverts commit 62405aa. Because after v2.6.0, nextTick always use microtask. There will be an update between 2 listener and block the v-model listener to update. We need to ensure the listener of v-model is triggered before listener with modifier to fix vuejs#11925.
JuniorTour
force-pushed
the
ensure-v-model-trigger-at-first
branch
from
d4b6041 to
0629e96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 62405aa.
Because after v2.6.0, nextTick always use microtask.
There will be an update between 2 listener and block the v-model listener to update.
We need to ensure the listener of v-model is triggered before listener with modifier to fix #11925.
Before: https://jsfiddle.net/fxdez9qh/
After: https://jsfiddle.net/juniortour/ty7ps0kw/
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: