Skip to content

Missing Vue import #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2020
Merged

Missing Vue import #1445

merged 2 commits into from
Feb 22, 2020

Conversation

quriosapien
Copy link
Contributor

@quriosapien quriosapien commented Feb 21, 2020

import Vue was missing in the code block.
when someone, new to vue tries to follow the guide, it becomes a pain-point to figure why test case which included Vue.nextTick() failed.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

`import Vue` was missing in the code block.
when someone, new to vue tries to follow the guide, it becomes a pain-point to figure why test case which included `Vue.nextTick()` failed.
@lmiller1990 lmiller1990 requested review from lmiller1990 and removed request for eddyerburgh February 22, 2020 01:16
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you will probably need to add comments to get this passing.

Eg:

import Vue from 'vue'

// ...
// ...

@quriosapien
Copy link
Contributor Author

Looks good, you will probably need to add comments to get this passing.

Eg:

import Vue from 'vue'

// ...
// ...

Done. It passed all the tests.

@lmiller1990
Copy link
Member

Great, thanks!

@lmiller1990 lmiller1990 merged commit ab35fab into vuejs:dev Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants