Skip to content

Hotfix: Fix clone issue with vue.extend components #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Hotfix: Fix clone issue with vue.extend components #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/create-instance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export default function createConstructor (component: Component, options: Option
compileTemplate(component)
}

const Constructor = vue.extend(component.extend ? component.options : component)
const Constructor = vue.extend(component)

if (options.mocks) {
addMocks(options.mocks, Constructor)
Expand Down
2 changes: 1 addition & 1 deletion src/mount.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import './lib/matches-polyfill'
Vue.config.productionTip = false

export default function mount (component: Component, options: Options = {}): VueWrapper {
const componentToMount = options.clone === false ? component : cloneDeep(component)
const componentToMount = options.clone === false ? component : cloneDeep(component.extend ? component.options : component)
// Remove cached constructor
delete componentToMount._Ctor

Expand Down
2 changes: 1 addition & 1 deletion src/shallow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import type VueWrapper from './wrappers/vue-wrapper'

export default function shallow (component: Component, options: Options = {}): VueWrapper {
const vue = options.localVue || Vue
const clonedComponent = cloneDeep(component)
const clonedComponent = cloneDeep(component.extend ? component.options : component)

if (clonedComponent.components) {
stubAllComponents(clonedComponent)
Expand Down