-
Notifications
You must be signed in to change notification settings - Fork 189
Add feature eventToObservable #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think per #44 , it would be ideal that It can be done by checking the presence of |
About #44 , I tried but |
@regou yeah, it will be bind (el, binding, vnode) {
// ...
if (vnode.componentInstance) {
// bind using vnode.componentInstance.$eventToObservable
} else {
// bind using Rx.fromEvent()
}
} |
Job done 💯
|
Excellent job! Thanks for the great contributions you've made to this project, I've added you as a collaborator :) |
Convert vm.$on to observable