Skip to content

Added VueRouter.version #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Added VueRouter.version #979

wants to merge 1 commit into from

Conversation

ytbryan
Copy link

@ytbryan ytbryan commented Dec 3, 2016

No description provided.

@posva
Copy link
Member

posva commented Dec 4, 2016

files in the dist directory are generated files, nothing should be added there. Also, it shouldn't start with a v
@fnlctrl Adding the version looks legit but we should add it to vuex as well to be consistent. WDYT?
@yyx990803 Shouldn't this https://github.com/vuejs/vue/blob/dev/src/core/index.js#L11 be added with a replace plugin, using something like __VERSION__ and then, in the rollup file, read the version from the package? This'd only work if the package is updated before bundling.

@fnlctrl
Copy link
Member

fnlctrl commented Dec 4, 2016

Yeah, maybe we should add versions to vuex/vue-router..

@yyx990803
Copy link
Member

@posva yes - both suggestions make sense. PR welcome.

@posva
Copy link
Member

posva commented Dec 4, 2016

@yyx990803 Ok, will do

@posva
Copy link
Member

posva commented Dec 4, 2016

@yyx990803 Actually, there's already a manual replacement done with a regex in vue to support another version for weex aswell.
I was thinking about using https://github.com/rollup/rollup-plugin-replace. I'll do so for vue-router and vuex.

posva added a commit to posva/vue-router that referenced this pull request Dec 6, 2016
posva added a commit that referenced this pull request Dec 6, 2016
@posva
Copy link
Member

posva commented Dec 7, 2016

Thanks for the suggestion @ytbryan 😉
Closing this in favor of #991

@posva posva closed this Dec 7, 2016
yyx990803 pushed a commit that referenced this pull request Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants