Fix .getAttribute on an element without this method #967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I had an error about
object doesn't support property or method 'getAttribute'
on IE (mainly Cordova on windows desktop) by clicking on a generated link by<router-link>
.When you click on the generated link, sometimes in
src/components/link.js
in the method https://github.com/AnthonySendra/vue-router/blob/d065e37e0e19f399597796b5257bfca3a5c79fd6/src/components/link.js#L85 thee.target
can be an instance of SVGElementInstance. But this object does not have the methodgetAttribute
. This error causes the application (Cordova) to crash.My fix will check if the object (the
e.target
) has the methodgetAttribute
before calling it.