Skip to content

Reports about the build needed for the demo work #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2016
Merged

Conversation

vinicius73
Copy link
Contributor

No description provided.

@vinicius73 vinicius73 changed the title Reports on the build needed for the demo work Reports about the build needed for the demo work Oct 20, 2016
@posva
Copy link
Member

posva commented Oct 20, 2016

I don't think this is necessary since there's an example at the bottom of the page

@vinicius73
Copy link
Contributor Author

This PR is based on feedback from my local community. More than one time they had doubts with this situation.

@posva
Copy link
Member

posva commented Oct 20, 2016

I'd rather add global note at the beginning of the guide: http://router.vuejs.org/en/essentials/getting-started.html

All examples will be using the standalone version of vue to make template parsing possible

@fnlctrl What are your thoughts on this?

@fnlctrl
Copy link
Member

fnlctrl commented Oct 20, 2016

Yeah, that should be enough.

@posva
Copy link
Member

posva commented Oct 20, 2016

@vinicius73 Do you find that statement clear enough?

@vinicius73
Copy link
Contributor Author

yes @posva is much better so I will update.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @fnlctrl

@posva posva merged commit 54608ef into vuejs:dev Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants