Allow calling instance methods before vue instantiation. (fix #795) #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…795) Previously it would throw errors. Allowed methods: push, replace, go, back, forward Reason: These methods only try to manipulate browser history, and should work even when root vue instance has not been created. Common use case: Call `router.replace()` to set browser url state. This action doesn't require vue's existence, so it shouldn't throw an error when called before vue's instantiation. Otherwise, users may need to check router's actual mode after fallback (history or hash) and then call `history.replaceState` or `location.replace` accordingly.
fnlctrl
commented
Oct 17, 2016
| * inside a `switch case`... | ||
| * Advices on how to remove this method are much appreciated. | ||
| */ | ||
| onHashChange () {} |
fnlctrl
commented
Oct 17, 2016
| this.history = new HashHistory(this, options.base, fallback) | ||
| this.history.transitionTo(getHash(), () => { | ||
| window.addEventListener('hashchange', () => { | ||
| this.history.onHashChange() |
There was a problem hiding this comment.
This is what made flow unhappy..
Error log (when you remove the dummy method in the comment above):
src/index.js:75
75: this.history.onHashChange()
^^^^^^^^^^^^ property `onHashChange`. Property not found in
75: this.history.onHashChange()
^^^^^^^^^^^^ AbstractHistory
src/index.js:75
75: this.history.onHashChange()
^^^^^^^^^^^^ property `onHashChange`. Property not found in
75: this.history.onHashChange()
^^^^^^^^^^^^ HTML5History
Even when this.history is guaranteed to have onHashChange inside case 'hash'
|
CI bug again... sigh.. |
|
I don't know yet how to handle that dummy function, but this function is worth some extra tests |
|
merged as 83418bc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would throw errors.
Allowed methods: push, replace, go, back, forward
Reason:
These methods only try to manipulate browser history, and should work even when root vue instance has not been created.
Common use case:
Call
router.replace()to set browser url state. This action doesn't require vue's existence, so it shouldn't throw an error when called before vue's instantiation.Otherwise, users may need to check router's actual mode after fallback (history or hash) and then call
history.replaceStateorlocation.replaceaccordingly.