Skip to content

Fix click event not bound for router-link (fix #707) #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2016
Merged

Fix click event not bound for router-link (fix #707) #708

merged 2 commits into from
Oct 13, 2016

Conversation

fnlctrl
Copy link
Member

@fnlctrl fnlctrl commented Oct 1, 2016

Fix click event not bound for <router-link> when tag is not <a> and doesn't have child <a>

@fnlctrl
Fix click event not bound for router-link (fix #707)
b3b7521 
Fix click event not bound for `<router-link>` when tag is not `<a>` and doesn't have child `<a>`
@posva
Copy link
Member

posva commented Oct 1, 2016

LGTM

@LinusBorg
Copy link
Member

Yeah this fallback is a good solution.

@marcvdm
Copy link

marcvdm commented Oct 10, 2016 •
edited
Loading

Any chance this can be merged soon?

@posva
Copy link
Member

posva commented Oct 10, 2016

@marcvdm We totally let this aside. @fnlctrl Can you add a test for this?

@fnlctrl
Copy link
Member Author

fnlctrl commented Oct 10, 2016

Yeah, will add it tomorrow... been really busy lately

On Tue, Oct 11, 2016, 01:37 Eduardo San Martin Morote <
notifications@github.com> wrote:

@marcvdm https://github.com/marcvdm We totally let this aside. @fnlctrl
https://github.com/fnlctrl Can you add a test for this?

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#708 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFTLl9Ls60tCw_1I9eEdV7mFP5Nq8P08ks5qynfAgaJpZM4KLtte
.

@fnlctrl
Copy link
Member Author

fnlctrl commented Oct 11, 2016 •
edited
Loading

@posva @yyx990803 @LinusBorg Done.

@LinusBorg
Copy link
Member

LGTM

1 similar comment
@posva
Copy link
Member

posva commented Oct 11, 2016

LGTM

@yyx990803 yyx990803 merged commit 541a543 into dev Oct 13, 2016
@fnlctrl fnlctrl deleted the fix-link-click-event branch October 17, 2016 15:01
@sjmlsxp
Copy link

sjmlsxp commented Oct 25, 2016

i want back 2.0.0 😭

@sjmlsxp
Copy link

sjmlsxp commented Oct 25, 2016

how to breaks navigation now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fnlctrl @posva @LinusBorg @marcvdm @sjmlsxp @yyx990803