Skip to content

test: Set NODE_ENV before error handling tests. #3712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2022
Merged

test: Set NODE_ENV before error handling tests. #3712

merged 1 commit into from
Feb 6, 2022

Conversation

iurisilvio
Copy link
Contributor

@iurisilvio iurisilvio commented Feb 5, 2022

Error handling tests fail depending on other tests ordering, because process.env.NODE_ENV can be production and this test file don't set NODE_ENV.

Fix #3712.

@netlify
Copy link

netlify bot commented Feb 5, 2022

✔️ Deploy Preview for vue-router-docs-v3 canceled.

🔨 Explore the source changes: 3b0d1a5

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-router-docs-v3/deploys/61febf5c4a7e200007aeafd4

@iurisilvio iurisilvio changed the title fix(test): Set NODE_ENV before error handling tests. fix(#3712): Set NODE_ENV before error handling tests. Feb 5, 2022
@posva posva changed the title fix(#3712): Set NODE_ENV before error handling tests. test: Set NODE_ENV before error handling tests. Feb 6, 2022
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva merged commit d76980c into vuejs:dev Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants