-
-
Notifications
You must be signed in to change notification settings - Fork 5k
fix(router): prevent memory leaks by removing app references from $router.apps once app destroyed (Fixes #2639) #2640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4e833a6
fix(router): remove app from $router.apps array once app destroyed (F…
tmorehouse 02eca65
lint
tmorehouse 646c294
lint
tmorehouse 614713a
Update index.js
tmorehouse c0fd03b
better handling of last app destroyed
tmorehouse 06d0b00
add app destroy testing
tmorehouse 743e0ff
Update api.spec.js
tmorehouse a90b3f1
Update api.spec.js
tmorehouse 2fe68ca
Update api.spec.js
tmorehouse 44dbc00
Update api.spec.js
tmorehouse 31dad30
Update api.spec.js
tmorehouse f9d556d
Update api.spec.js
tmorehouse e724261
Update api.spec.js
tmorehouse 7780df0
Merge pull request #1 from vuejs/dev
tmorehouse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.