Skip to content

[Korean] Update vue-router 2.5 #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2017
Merged

[Korean] Update vue-router 2.5 #1370

merged 2 commits into from
Apr 26, 2017

Conversation

ChangJoo-Park
Copy link
Contributor

No description provided.

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
Please check my review comment 💬


> 2.5.0에서 추가됨

In 2.5.0+ you can register a global guard with `router.onResolve`. This is similar to `router.beforeEach`, with the difference that resolve guards will be called right before the navigation is confirmed, **after all in-component guards and async route components are resolved**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, It is my mistake 😭

Global Resolve Guards and Global After Hooks headings are not need to translate in Korean. It is make sense in English than Korean
@ChangJoo-Park
Copy link
Contributor Author

Sorry @kazupon 😭 I forgot to remove original sentences

@kazupon kazupon merged commit c021235 into vuejs:dev Apr 26, 2017
@kazupon
Copy link
Member

kazupon commented Apr 26, 2017

Thanks!

@ChangJoo-Park
Copy link
Contributor Author

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants