Skip to content

Bump dependencies(minor/patch) #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Conversation

sudo-suhas
Copy link

Updated dependencies

Dependencies

Package Current Latest Reason
postcss 6.0.6 6.0.8 Fix Node.js 4.2.2 support, Fix base64 decoding for old Node.js and browser
resolve 1.3.3 1.4.0 fix when package.json main = ‘.’, add preserveSymlinks option

Dev-Dependencies

Package Current Latest Reason
coffee-script 1.12.6 1.12.7 Fix regressions related to chained func calls and indented return and throw arguments
js-yaml 3.9.0 3.9.1 Ensure stack is present for custom errors in node 7.+
inject-loader 3.0.0 3.0.1 set compact to false and provide filename to babel, Add webpack 3 peerDependency
vue 2.4.1 2.4.2
vue-server-renderer 2.4.1 2.4.2 Not sure
vue-template-compiler 2.4.1 2.4.2 Not sure
webpack 3.3.0 3.4.1 Features, bug fixes, perf

NOTE: No major version update is present in this PR.

This PR fixes a warning:

"inject-loader@3.0.0" has incorrect peer dependency "webpack@^1 || ^2"

This was the main intent of the PR. But I figured, while I am at it, might as well update the rest

@sudo-suhas
Copy link
Author

ping @yyx990803

@yyx990803
Copy link
Member

yyx990803 commented Sep 18, 2017

Thanks! Although I'm wondering if patch/minor bumps are necessary since we are using a semver range with ^ - users automatically get the latest patch and minor releases.

@sudo-suhas
Copy link
Author

Probably not for the end users. But the lock file will mean that collaborators will install older versions.

@yyx990803
Copy link
Member

That's true. Would you mind resolving the conflicts (we just released a hotfix)?

@sudo-suhas
Copy link
Author

Sure, no problem. Is it alright if I do it by tomorrow?

@yyx990803
Copy link
Member

Sure! Take your time.

@sudo-suhas
Copy link
Author

@yyx990803 Rebase done.

@yyx990803
Copy link
Member

Mind removing .vscode from the PR?

@sudo-suhas
Copy link
Author

My apologies! Doing it now.

@sudo-suhas
Copy link
Author

I have removed .vscode from the PR. I added it by mistake while rebasing.

@yyx990803 yyx990803 merged commit 39af4fc into vuejs:master Sep 19, 2017
@yyx990803
Copy link
Member

Thanks!

@sudo-suhas
Copy link
Author

I love working with Vue.js and very very happy to help!

@sudo-suhas sudo-suhas deleted the chore/bump-deps branch September 19, 2017 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants