Skip to content

add missing comma #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2017
Merged

add missing comma #690

merged 1 commit into from
Mar 6, 2017

Conversation

guylyons
Copy link

@guylyons guylyons commented Mar 6, 2017

tiny fix, just missing comma in JSON example

kazupon
kazupon reviewed Mar 6, 2017
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks of your PR!
Good catch!

Could you fix other languages(ru, kr, pt_BR) please?

@guylyons
Copy link
Author

guylyons commented Mar 6, 2017

np! i've updated ru and pt_BR, but kr appears to be out of date and did not contain those lines of json.

@kazupon
Copy link
Member

kazupon commented Mar 6, 2017

Thanks!

@kazupon kazupon merged commit d8878d1 into vuejs:master Mar 6, 2017
@guylyons guylyons deleted the patch-1 branch March 6, 2017 17:26
xalexec pushed a commit to Transnal/vue-loader that referenced this pull request Mar 26, 2017
@guylyons @kazupon
add missing comma (vuejs#690)
76e8cc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guylyons @kazupon