feat: configuring Pug compiler from vue-jest configuration #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
We have a set of reusable Vue components that share a lot of functionality and also some features within the template. Since Vue doesn't seem to have a clear way of extending templates, I'm using Pug to define a base template and include it into the child templates (a similar way to how it's done in this article).
All works well and nicely with our Webpack build, but those changes broke our tests. I traced the problem into vue-jest and the fact that there is no way to give the Pug compiler any configuration options. When one is using e.g. absolute paths, Pug requires a 'basedir' attribute to be given, otherwise it will complain and refuse to compile anything.
So, here's a PR that implements support for configuring the Pug compiler via Jest globals! :) The configuration is passed via
'vue-jest': { pug: { basedir: 'mybasedir' } }. Also updated the tests and readme.