TSConfig defaults is a dead code path

[dcherman]

The default tsconfig here

vue-jest/lib/compilers/typescript-compiler.js

Lines 8 to 30 in 9cef21f

	const defaultTypescriptConfig = {
	'compilerOptions': {
	'target': 'es5',
	'lib': [
	'dom',
	'es6'
	],
	'module': 'es2015',
	'moduleResolution': 'node',
	'types': ['vue-typescript-import-dts', 'jest', 'node'],
	'isolatedModules': false,
	'experimentalDecorators': true,
	'noImplicitAny': true,
	'noImplicitThis': true,
	'strictNullChecks': true,
	'removeComments': true,
	'emitDecoratorMetadata': true,
	'suppressImplicitAnyIndexErrors': true,
	'allowSyntheticDefaultImports': true,
	'sourceMap': true,
	'allowJs': true
	}
	}

Will never be hit since loadSync provides an empty set of defaults if no tsconfig.json is found

https://github.com/TypeStrong/tsconfig/blob/5281eafd459a574343bab1bfb8d2ec004cd07355/src/tsconfig.ts#L142-L148

Which means this condition is never falsy in any scenario

vue-jest/lib/compilers/typescript-compiler.js

Lines 39 to 43 in 9cef21f

	if (!config) {
	logger.info('no tsconfig.json found, defaulting to default typescript options')
	}
	const typescriptConfig = config || defaultTypescriptConfig

We should probably swap that out for resolveSync to see if we would have found a tsconfig.json before attempting to load it if we want these defaults to be used.

[dcherman]

Alternatively, it looks like they also provide path on the returned value if it's found from loadSync, else it's undefined. Can easily check to see if a path exists instead.

[eddyerburgh]

Thanks for the bug report. Would you like to make a PR?

[dcherman]

@eddyerburgh Yep, already done. Just had to write some tests / refactor the code a bit to do so.