fix(webpack): slash on publicPath: 'auto' #6506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomicakr
changed the title
|
BASE_URL was changed to 'auto'， how to solve it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
Webpack 5 introduced an 'auto' publicPath feature in webpack/pull/11258. The
ensureSlashwill currently add the slash regardless of the actual public path, so the feature would be obsolete.I encountered the problem while creating a micro-frontend with the webpack 5's module federation. We want the public path to be the one micro frontend is deployed to, which webpack can automatically infer(module-federation/#infer-publicpath-from-script, there is a tip at the end of the paragraph).