Skip to content

feat(cli-service): allow override from option in pages config #5534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

yoyo930021
Copy link
Member

@yoyo930021 yoyo930021 commented May 28, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:
By example:
I have https://example.com, and have two version pages for mobile, desktop.

  1. When type https://example.com, user go to a redirect page for screen size.
  2. When type https://example.com/d, user go to a desktop page.
  3. When type https://example.com/m, user go to a mobile page.
  4. When type https://example.com/m/, user go to a mobile page.
  5. When type https://example.com/message, user go to a redirect page for screen size.

Now it's impossible to meet all the conditions.

// vue.config.js
module.exports = {
  pages: {
    index: 'src/entry.ts',
    m: 'src/mobile/main.ts',
    d: 'src/desktop/main.ts'
  }
}

The fifth condition is not met when this config, user will go to a mobile page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants