Skip to content

feat: implement a migrator to upgrade to eslint 6 #5085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 27, 2020

Conversation

haoqunjiang
Copy link
Member

TODO:

  • Tests (would like to open another PR to make the migrator easier to test first)
  • Documentation? Not sure where to put it.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

@haoqunjiang haoqunjiang changed the title Feat eslint migrator feat: implement a migrator to upgrade to eslint 6 Jan 16, 2020
@pksunkara
Copy link
Contributor

@sodatea Do ping me once this is ready for review.

@haoqunjiang haoqunjiang marked this pull request as ready for review January 26, 2020 13:05
@haoqunjiang
Copy link
Member Author

@pksunkara
Ready for review.
The upgrader tests fail quite frequently due to timeouts. I'll find some other time to try to make them work with yarn --offline. But that shouldn't block this PR IMO.

@haoqunjiang haoqunjiang merged commit a468abf into vuejs:dev Jan 27, 2020
@haoqunjiang haoqunjiang deleted the feat-eslint-migrator branch January 27, 2020 06:00
mactanxin pushed a commit to mactanxin/vue-cli that referenced this pull request Feb 11, 2020
* refactor: extract deps & config logic to separate files

* feat: implement a migrator to upgrade to eslint 6

* fix: add required deps for eslint v4

* test: move migrator tests to each standalone plugins

* refactor: use spread operator instead of Object.assign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants