Skip to content

feat(babel): transform preset names in the plugin migrator #4629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ packages/test
temp
entry-wc.js
dist
__testfixtures__
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
module.exports = {
presets: [
["@vue/app", {
polyfills: []
}]
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
module.exports = {
presets: [
["@vue/cli-plugin-babel/preset", {
polyfills: []
}]
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module.exports = {
presets: ["@vue/app"]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module.exports = {
presets: ["@vue/cli-plugin-babel/preset"]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
const config = {
presets: [
[require("@vue/babel-preset-app"), {
polyfills: []
}]
]
}

module.exports = config
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
const config = {
presets: [
[require("@vue/cli-plugin-babel/preset"), {
polyfills: []
}]
]
}

module.exports = config
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module.exports = {
presets: [`@vue/app`]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module.exports = {
presets: [`@vue/cli-plugin-babel/preset`]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
jest.autoMockOff()

const { defineTest } = require('jscodeshift/dist/testUtils')

defineTest(__dirname, 'usePluginPreset', null, 'default')
defineTest(__dirname, 'usePluginPreset', null, 'customConfig')
defineTest(__dirname, 'usePluginPreset', null, 'require')
defineTest(__dirname, 'usePluginPreset', null, 'templateLiteral')

41 changes: 41 additions & 0 deletions packages/@vue/cli-plugin-babel/codemods/usePluginPreset.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
module.exports = function (fileInfo, api) {
const j = api.jscodeshift
const root = j(fileInfo.source)

root
.find(j.Literal, { value: '@vue/app' })
.forEach(({ node }) => {
node.value = '@vue/cli-plugin-babel/preset'
})
root
.find(j.Literal, { value: '@vue/babel-preset-app' })
.forEach(({ node }) => {
node.value = '@vue/cli-plugin-babel/preset'
})

const templateLiterals = root
.find(j.TemplateLiteral, {
expressions: { length: 0 }
})

templateLiterals
.find(j.TemplateElement, {
value: {
cooked: '@vue/app'
}
})
.forEach(({ node }) => {
node.value = { cooked: '@vue/cli-plugin-babel/preset', raw: '@vue/cli-plugin-babel/preset' }
})
templateLiterals
.find(j.TemplateElement, {
value: {
cooked: '@vue/babel-preset-app'
}
})
.forEach(({ node }) => {
node.value = { cooked: '@vue/cli-plugin-babel/preset', raw: '@vue/cli-plugin-babel/preset' }
})

return root.toSource()
}
12 changes: 2 additions & 10 deletions packages/@vue/cli-plugin-babel/migrator/index.js
Original file line number Diff line number Diff line change
@@ -1,23 +1,15 @@
const { chalk } = require('@vue/cli-shared-utils')

module.exports = (api) => {
// TODO: backport this part to v3
// if (api.fromVersion('<=3.5.3')) {
// // add core-js@2 as dependency
// api.extendPackage({
// dependencies: {
// 'core-js': '^2.6.5'
// }
// })
// }

if (api.fromVersion('^3')) {
api.extendPackage({
dependencies: {
'core-js': '^3.1.2'
}
}, true)

api.transformScript('babel.config.js', require('../codemods/usePluginPreset'))

// TODO: implement a codemod to migrate polyfills
api.exitLog(`core-js has been upgraded from v2 to v3.
If you have any custom polyfills defined in ${chalk.yellow('babael.config.js')}, please be aware their names may have been changed.
Expand Down
3 changes: 3 additions & 0 deletions packages/@vue/cli-plugin-babel/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@
"peerDependencies": {
"@vue/cli-service": "^3.0.0 || ^4.0.0-0"
},
"devDependencies": {
"jscodeshift": "^0.6.4"
},
"publishConfig": {
"access": "public"
}
Expand Down