Skip to content

chore: plugins should list @vue/cli-service in peerDependencies #4365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/dev-guide/generator-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ The version string for the **project local** `@vue/cli-service` version that is

Nothing happens if the provided version is satisfied. Otherwise, an error will be thrown.

Note: It's recommended to use [the `peerDependencies` field in `package.json`](https://docs.npmjs.com/files/package.json#peerdependencies) under most circumstances.


## resolve

Expand Down
2 changes: 2 additions & 0 deletions docs/dev-guide/plugin-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ The version string for the `@vue/cli-service` version that is loading the plugin

Nothing happens if the provided version is satisfied. Otherwise, an error will be thrown.

Note: It's recommended to use [the `peerDependencies` field in `package.json`](https://docs.npmjs.com/files/package.json#peerdependencies) under most circumstances.

## getCwd

- **Usage**:
Expand Down
3 changes: 3 additions & 0 deletions packages/@vue/cli-plugin-babel/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
"babel-loader": "^8.0.6",
"webpack": ">=4 < 4.29"
},
"peerDependencies": {
"@vue/cli-service": "^3.0.0 || ^4.0.0-0"
},
"publishConfig": {
"access": "public"
}
Expand Down
3 changes: 3 additions & 0 deletions packages/@vue/cli-plugin-e2e-cypress/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,8 @@
"@vue/cli-shared-utils": "^4.0.0-beta.1",
"cypress": "^3.3.1",
"eslint-plugin-cypress": "^2.2.1"
},
"peerDependencies": {
"@vue/cli-service": "^3.0.0 || ^4.0.0-0"
}
}
1 change: 1 addition & 0 deletions packages/@vue/cli-plugin-e2e-nightwatch/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"chromedriver": "^74.0.0"
},
"peerDependencies": {
"@vue/cli-service": "^3.0.0 || ^4.0.0-0",
"chromedriver": "*"
}
}
1 change: 1 addition & 0 deletions packages/@vue/cli-plugin-eslint/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"yorkie": "^2.0.0"
},
"peerDependencies": {
"@vue/cli-service": "^3.0.0 || ^4.0.0-0",
"eslint": ">= 1.6.0"
}
}
3 changes: 3 additions & 0 deletions packages/@vue/cli-plugin-pwa/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,8 @@
},
"devDependencies": {
"register-service-worker": "^1.6.2"
},
"peerDependencies": {
"@vue/cli-service": "^3.0.0 || ^4.0.0-0"
}
}
3 changes: 3 additions & 0 deletions packages/@vue/cli-plugin-router/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,8 @@
},
"devDependencies": {
"@vue/cli-test-utils": "^4.0.0-beta.1"
},
"peerDependencies": {
"@vue/cli-service": "^3.0.0 || ^4.0.0-0"
}
}
1 change: 1 addition & 0 deletions packages/@vue/cli-plugin-typescript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"yorkie": "^2.0.0"
},
"peerDependencies": {
"@vue/cli-service": "^3.0.0 || ^4.0.0-0",
"typescript": ">=2"
},
"devDependencies": {
Expand Down
3 changes: 3 additions & 0 deletions packages/@vue/cli-plugin-unit-jest/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,8 @@
"devDependencies": {
"@vue/test-utils": "1.0.0-beta.29",
"ts-jest": "^24.0.2"
},
"peerDependencies": {
"@vue/cli-service": "^3.0.0 || ^4.0.0-0"
}
}
3 changes: 3 additions & 0 deletions packages/@vue/cli-plugin-unit-mocha/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@
"@vue/test-utils": "1.0.0-beta.29",
"chai": "^4.1.2"
},
"peerDependencies": {
"@vue/cli-service": "^3.0.0 || ^4.0.0-0"
},
"publishConfig": {
"access": "public"
}
Expand Down
3 changes: 3 additions & 0 deletions packages/@vue/cli-plugin-vuex/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,8 @@
},
"devDependencies": {
"@vue/cli-test-utils": "^4.0.0-beta.1"
},
"peerDependencies": {
"@vue/cli-service": "^3.0.0 || ^4.0.0-0"
}
}