fix(cli-service): inspect --rules (close #3334) #3378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should only return rules that actually have a name (= which were added with the chainWebpack API) close #3334
|
I think we need a default / placeholder name for such rules, otherwise the result might be misleading. |
|
Agreed. We would then also need to mark those rules with e..g an asterisk and explain belog the list that entries marked with an asterisk can't be accessed with Will make changes accordingly. |
|
@sodatea I made the changes. Also noticed we didn't really have tests for the inspect command (unless I failed to find them?) I tested the changes and they work, but i could take the opportunity and come up with a few tests for Might take me a while though |
… into LinusBorg-patch-issue-3334 * 'LinusBorg-patch-issue-3334' of github.com:vuejs/vue-cli: fix: conditional # Conflicts: # packages/@vue/cli-service/lib/commands/inspect.js
LinusBorg
changed the title
haoqunjiang
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should only return rules that actually have a name
(= which were added with the chainWebpack API)
close #3334
Alternative: Instead of filtering these cases, we could add a default name to inform the user that there are rules not included in this list?